Skip to content

fix: remove all None authors, not just first #10044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jennifer-richards merged 1 commit into from
Dec 3, 2025
Merged

fix: remove all None authors, not just first #10044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ietf/doc/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ def authors(self):
log.log(
Copy link
Copy Markdown
Member

@kesara kesara Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the log message?

Copy link
Copy Markdown
Member Author

@jennifer-richards jennifer-richards Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - it still doesn't handle them properly, it just doesn't fail. Authors without a person are omitted from the return value.

Copy link
Copy Markdown
Member Author

@jennifer-richards jennifer-richards Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well.. I guess we could remove it if it's being hit often enough to cause problems. Its main purpose was to be sure we didn't forget the todo on L467

f"FIXME: authors() cannot handle non-Person authors in {self}"
)
rfc_authors.remove(None)
rfc_authors = [author for author in rfc_authors if author is not None]
return rfc_authors
return [ a.person for a in self.documentauthor_set.all() ]

Expand Down