fix: remove all None authors, not just first#10044
Merged
jennifer-richards merged 1 commit intoietf-tools:feat/rpc-apifrom Dec 3, 2025
Merged
fix: remove all None authors, not just first#10044jennifer-richards merged 1 commit intoietf-tools:feat/rpc-apifrom
jennifer-richards merged 1 commit intoietf-tools:feat/rpc-apifrom
Conversation
rjsparks
approved these changes
Dec 2, 2025
kesara
reviewed
Dec 2, 2025
| @@ -470,7 +470,7 @@ def authors(self): | |||
| log.log( | |||
Member
Author
There was a problem hiding this comment.
No - it still doesn't handle them properly, it just doesn't fail. Authors without a person are omitted from the return value.
Member
Author
There was a problem hiding this comment.
Well.. I guess we could remove it if it's being hit often enough to cause problems. Its main purpose was to be sure we didn't forget the todo on L467
kesara
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.