updating forked version #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ files so v1 and v2 have their own versions of 'router'.
…d to change them to work with new implementation
V1 to fast api
docs: add ibhuiyan17 as a contributor
* add invoke as dev dependency * invoke tasks * add invoke check cmd update pipenv scripts and make commands * optional --diff * lint and test * update docs remove Flask as a project requirement add invoke commands * add lint and test to Pipenv scripts, update docs
* remove flask * sort dependencies * add coveralls badge * add coveralls * update make test to create coverage reports * split script commands, add coveralls upload step * remove unneeded modules and imports * regenerate lockfile
* lint fixes * re-enable CI failure on lint warnings * edit lint config * white list pydantic * allow fstring logging * allow TODO * temporarily allow duplicate code
Co-authored-by: Rostislav Svoboda <[email protected]>
These are required to be able to test asyncio functionality, as well as making ASGI test clients play nice asynchronously.
- Move test fixtures into tests/fixtures.py - Update test fixtures to mock aiohttp.ClientSession.get, instead of requests.get - Add a context manager to replace the global httputils.client_session with an AsyncMock - Misc. cleanup
I didn't see this file when I first added the new fixtures.
One can still define a separate responder function here, but since this is the only response defined for the tests thus far, this seems like a reasonable default.
Using these as decorators causes a lot of problems when combined with Pytest fixtures, often resulting in the mock not applying.
#232: Make all endpoints async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.