V1 to fast api #228
Merged
V1 to fast api #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ files so v1 and v2 have their own versions of 'router'.
…d to change them to work with new implementation
Contributor
Author
|
Not sure why it failed the build. Any tips on this? |
Owner
|
Hey! The tests are failing because you haven't run the formatters:
|
Closed
Owner
|
Well done, and youve tested that the endpoints work? |
Contributor
Author
|
Yep, looks to be working on my end |
Owner
|
@all-contributors please add @ibhuiyan17 for code. |
Contributor
|
I've put up a pull request to add @ibhuiyan17! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed transfer of v1 to use FastAPI and passing the currently existing tests. As of this PR, it works as 2 separate routers for v1 and v2 which are imported in main.py as v1router and v2router. These are then added to APP with APP.include_router(v1router, prefix=""), etc. If you guys had a different design in mind, please let me know.