Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions app/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@
import uvicorn
from fastapi import FastAPI, Request, Response
from fastapi.middleware.cors import CORSMiddleware
from fastapi.middleware.wsgi import WSGIMiddleware
from fastapi.responses import JSONResponse

from .core import create_app
from .data import data_source
from .models.latest import LatestResponse as Latest
from .models.location import LocationResponse as Location
from .models.location import LocationsResponse as Locations
from .router import router
from .router.v1 import router as v1router
from .router.v2 import router as v2router

# ############
# FastAPI App
Expand Down Expand Up @@ -83,11 +83,9 @@ async def handle_validation_error(request: Request, exc: pydantic.error_wrappers


# Include routers.
APP.include_router(router, prefix="/v2", tags=["v2"])
APP.include_router(v1router, prefix="", tags=["v1"])
APP.include_router(v2router, prefix="/v2", tags=["v2"])

# mount the existing Flask app
# v1 @ /
APP.mount("/", WSGIMiddleware(create_app()))

# Running of app.
if __name__ == "__main__":
Expand Down
5 changes: 2 additions & 3 deletions app/router/__init__.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from fastapi import APIRouter

# Create the router.
router = APIRouter()
from .v1 import all, confirmed, deaths, recovered

# The routes.
from . import latest, sources, locations # isort:skip
from .v2 import latest, sources, locations # isort:skip
3 changes: 3 additions & 0 deletions app/router/v1/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from fastapi import APIRouter

router = APIRouter()
19 changes: 19 additions & 0 deletions app/router/v1/all.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
from ...services.location.jhu import get_category
from . import router


@router.get("/all")
def all():
# Get all the categories.
confirmed = get_category("confirmed")
deaths = get_category("deaths")
recovered = get_category("recovered")

return {
# Data.
"confirmed": confirmed,
"deaths": deaths,
"recovered": recovered,
# Latest.
"latest": {"confirmed": confirmed["latest"], "deaths": deaths["latest"], "recovered": recovered["latest"],},
}
9 changes: 9 additions & 0 deletions app/router/v1/confirmed.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
from ...services.location.jhu import get_category
from . import router


@router.get("/confirmed")
def confirmed():
confirmed = get_category("confirmed")

return confirmed
9 changes: 9 additions & 0 deletions app/router/v1/deaths.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
from ...services.location.jhu import get_category
from . import router


@router.get("/deaths")
def deaths():
deaths = get_category("deaths")

return deaths
9 changes: 9 additions & 0 deletions app/router/v1/recovered.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
from ...services.location.jhu import get_category
from . import router


@router.get("/recovered")
def recovered():
recovered = get_category("recovered")

return recovered
3 changes: 3 additions & 0 deletions app/router/v2/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from fastapi import APIRouter

router = APIRouter()
4 changes: 2 additions & 2 deletions app/router/latest.py → app/router/v2/latest.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from fastapi import Request

from ..enums.sources import Sources
from ..models.latest import LatestResponse as Latest
from ...enums.sources import Sources
from ...models.latest import LatestResponse as Latest
from . import router


Expand Down
6 changes: 3 additions & 3 deletions app/router/locations.py → app/router/v2/locations.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
from fastapi import HTTPException, Request

from ..enums.sources import Sources
from ..models.location import LocationResponse as Location
from ..models.location import LocationsResponse as Locations
from ...enums.sources import Sources
from ...models.location import LocationResponse as Location
from ...models.location import LocationsResponse as Locations
from . import router


Expand Down
2 changes: 1 addition & 1 deletion app/router/sources.py → app/router/v2/sources.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from ..data import data_sources
from ...data import data_sources
from . import router


Expand Down
13 changes: 0 additions & 13 deletions app/routes/__init__.py

This file was deleted.

Empty file removed app/routes/v1/__init__.py
Empty file.
23 changes: 0 additions & 23 deletions app/routes/v1/all.py

This file was deleted.

9 changes: 0 additions & 9 deletions app/routes/v1/confirmed.py

This file was deleted.

9 changes: 0 additions & 9 deletions app/routes/v1/deaths.py

This file was deleted.

9 changes: 0 additions & 9 deletions app/routes/v1/recovered.py

This file was deleted.

26 changes: 11 additions & 15 deletions tests/test_routes.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
import pytest
from fastapi.testclient import TestClient

import app
from app import services
# import app
# from app import services
from app.main import APP

from .test_jhu import DATETIME_STRING, mocked_requests_get, mocked_strptime_isoformat
Expand All @@ -22,11 +22,7 @@ class FlaskRoutesTest(unittest.TestCase):
Store all integration testcases in one class to ensure app context
"""

# load app context only once.
app = app.create_app()

def setUp(self):
self.client = FlaskRoutesTest.app.test_client()
self.asgi_client = TestClient(APP)
self.date = DATETIME_STRING

Expand All @@ -48,36 +44,36 @@ def test_v1_confirmed(self, mock_request_get, mock_datetime):
mock_datetime.strptime.side_effect = mocked_strptime_isoformat
state = "confirmed"
expected_json_output = self.read_file_v1(state=state)
return_data = self.client.get("/{}".format(state)).data.decode()
return_data = self.asgi_client.get("/{}".format(state)).json()

assert return_data == expected_json_output
assert return_data == json.loads(expected_json_output)

def test_v1_deaths(self, mock_request_get, mock_datetime):
mock_datetime.utcnow.return_value.isoformat.return_value = self.date
mock_datetime.strptime.side_effect = mocked_strptime_isoformat
state = "deaths"
expected_json_output = self.read_file_v1(state=state)
return_data = self.client.get("/{}".format(state)).data.decode()
return_data = self.asgi_client.get("/{}".format(state)).json()

assert return_data == expected_json_output
assert return_data == json.loads(expected_json_output)

def test_v1_recovered(self, mock_request_get, mock_datetime):
mock_datetime.utcnow.return_value.isoformat.return_value = self.date
mock_datetime.strptime.side_effect = mocked_strptime_isoformat
state = "recovered"
expected_json_output = self.read_file_v1(state=state)
return_data = self.client.get("/{}".format(state)).data.decode()
return_data = self.asgi_client.get("/{}".format(state)).json()

assert return_data == expected_json_output
assert return_data == json.loads(expected_json_output)

def test_v1_all(self, mock_request_get, mock_datetime):
mock_datetime.utcnow.return_value.isoformat.return_value = self.date
mock_datetime.strptime.side_effect = mocked_strptime_isoformat
state = "all"
expected_json_output = self.read_file_v1(state=state)
return_data = self.client.get("/{}".format(state)).data.decode()
# print(return_data)
assert return_data == expected_json_output
return_data = self.asgi_client.get("/{}".format(state)).json()

assert return_data == json.loads(expected_json_output)

def test_v2_latest(self, mock_request_get, mock_datetime):
mock_datetime.utcnow.return_value.isoformat.return_value = DATETIME_STRING
Expand Down