Skip to content

Commit b945275

Browse files
committed
Merged [7386] from tterriberry@mozilla.com: Describe needed positions in document ballot mail.
This uses doc.utils.needed_ballot_positions() to calculate what is needed. Fixes ietf-tools#924. - Legacy-Id: 7405 Note: SVN reference [7386] has been migrated to Git commit d42ccbe
2 parents 8ff8056 + d42ccbe commit b945275

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

ietf/doc/mails.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
from ietf.utils.mail import send_mail, send_mail_text
1111
from ietf.ipr.search import iprs_from_docs, related_docs
1212
from ietf.doc.models import WriteupDocEvent, BallotPositionDocEvent, LastCallDocEvent, DocAlias, ConsensusDocEvent, DocTagName
13+
from ietf.doc.utils import needed_ballot_positions
1314
from ietf.person.models import Person
1415
from ietf.group.models import Group, Role
1516
from ietf.doc.utils import needed_ballot_positions
@@ -374,7 +375,10 @@ def formatted(val):
374375
last_call_expires=last_call_expires,
375376
approval_text=approval_text,
376377
ballot_writeup=ballot_writeup,
377-
approvalneeds=needed_ballot_positions(doc, positions),
378+
needed_ballot_positions=
379+
needed_ballot_positions(doc,
380+
doc.active_ballot().active_ad_positions().values()
381+
),
378382
)
379383
)
380384

ietf/templates/doc/mail/issue_ballot_mail.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Subject: Evaluation: {{ doc.file_tag }} to {{ doc|std_level_prompt }}
1717
{% for fmt in inactive_ad_positions %}{{ fmt }}
1818
{% endfor %}{% endif %}
1919

20-
{{ approvalneeds }}
20+
{% filter wordwrap:73 %}{{ needed_ballot_positions }}{% endfilter %}
2121

2222
DISCUSSES AND COMMENTS
2323
======================

0 commit comments

Comments
 (0)