Skip to content

Commit d42ccbe

Browse files
author
Timothy B. Terriberry
committed
Describe needed positions in document ballot mail.
This uses doc.utils.needed_ballot_positions() to calculate what is needed. Fixes ietf-tools#924. Commit ready to merge. - Legacy-Id: 7386
1 parent 8b049ec commit d42ccbe

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

ietf/doc/mails.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
from ietf.utils.mail import send_mail, send_mail_text
1111
from ietf.ipr.search import iprs_from_docs, related_docs
1212
from ietf.doc.models import WriteupDocEvent, BallotPositionDocEvent, LastCallDocEvent, DocAlias, ConsensusDocEvent, DocTagName
13+
from ietf.doc.utils import needed_ballot_positions
1314
from ietf.person.models import Person
1415
from ietf.group.models import Group, Role
1516

@@ -373,6 +374,10 @@ def formatted(val):
373374
last_call_expires=last_call_expires,
374375
approval_text=approval_text,
375376
ballot_writeup=ballot_writeup,
377+
needed_ballot_positions=
378+
needed_ballot_positions(doc,
379+
doc.active_ballot().active_ad_positions().values()
380+
),
376381
)
377382
)
378383

ietf/templates/doc/mail/issue_ballot_mail.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@ Subject: Evaluation: {{ doc.file_tag }} to {{ doc|std_level_prompt }}
1717
{% for fmt in inactive_ad_positions %}{{ fmt }}
1818
{% endfor %}{% endif %}
1919

20-
"Yes" or "No-Objection" positions from 2/3 of non-recused ADs,
21-
with no "Discuss" positions, are needed for approval.
20+
{% filter wordwrap:73 %}{{ needed_ballot_positions }}{% endfilter %}
2221

2322
DISCUSSES AND COMMENTS
2423
======================

0 commit comments

Comments
 (0)