Skip to content

feat(a11y): enhance label and state for view all button #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jezzamonn merged 3 commits into from
Dec 21, 2025
Merged

feat(a11y): enhance label and state for view all button #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fa33d8
feat(a11y): santa button should accept aria-expanded
KenTandrian Dec 21, 2025
177570d
feat(a11y): update label and expanded for santa buttons
KenTandrian Dec 21, 2025
597ce30
fix(msg): update messages
KenTandrian Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _messages/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
"message": "The Calendar"
},
"category_all": {
"message": "View All"
"message": "View All Menu"
},
"category_android": {
"message": "Android"
Expand Down
2 changes: 1 addition & 1 deletion en_src_messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@
},
"category_all": {
"description": "Button text. Category label that shows all games.",
"message": "View All"
"message": "View All Menu"
},
"category_android": {
"description": "Button text. Category label that shows games available on Android devices.",
Expand Down
3 changes: 3 additions & 0 deletions static/src/elements/santa-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import {html, LitElement} from 'lit-element';
import {nothing} from 'lit-html';
import {ifDefined} from 'lit-html/directives/if-defined';
import * as common from '../../src/core/common.js';
import styles from './santa-button.css';

Expand All @@ -39,6 +40,7 @@ export class SantaButtonElement extends LitElement {
path: {type: String},
color: {type: String},
disabled: {type: Boolean, reflect: true},
ariaExpanded: {attribute: 'aria-expanded'},
ariaLabel: {reflect: true, attribute: 'aria-label'}
};
}
Expand Down Expand Up @@ -86,6 +88,7 @@ export class SantaButtonElement extends LitElement {
class="${this.color || ''}"
.disabled=${this.disabled}
@click=${this._maybePreventClick}
aria-expanded=${ifDefined(this.ariaExpanded || undefined)}
aria-label=${this.ariaLabel || nothing}>${inner}</button>`;
}

Expand Down
3 changes: 2 additions & 1 deletion static/src/elements/santa-chrome.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/

import {html, LitElement} from 'lit-element';
import {ifDefined} from 'lit-html/directives/if-defined';
import styles from './santa-chrome.css';
import * as prefix from '../lib/prefix.js';
import './santa-button.js';
Expand Down Expand Up @@ -100,7 +101,7 @@ export class SantaChromeElement extends LitElement {
</div>
<div id="padder">
<header>
<santa-button class="menu-button" aria-label=${labelForMenu} @click=${this._onMenuClick} path=${this.showHome ? paths.home : paths.menu}></santa-button>
<santa-button class="menu-button" aria-label=${labelForMenu} aria-expanded=${ifDefined(this.showHome ? undefined : this.navOpen)} @click=${this._onMenuClick} path=${this.showHome ? paths.home : paths.menu}></santa-button>
<santa-button .hidden=${isAndroid()} aria-label=${labelForAudio} color=${this.muted ? 'purple' : ''} @click=${this._onAudioClick} path=${this.muted ? paths.unmute : paths.mute}></santa-button>
<santa-button aria-label=${labelForAction} ?disabled=${!this.action} @click=${this._onActionClick} path=${paths[this.action || this._lastAction] || ''}></santa-button>
<div class="grow"></div>
Expand Down