feat(a11y): enhance label and state for view all button#229
Merged
Jezzamonn merged 3 commits intoDec 21, 2025
Conversation
Collaborator
Author
|
Expanded: 
Collapsed: 
|
Collaborator
|
Nice! We'll need to update our internal translations for the other languages too, but good to fix this for English for the moment. |
Jezzamonn
approved these changes
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the accessibility of the "View All" (hamburger) menu button by ensuring it correctly announces its purpose and current state to screen reader users.
Changes
santa-chrome.jsto change based on context. It now clearly announces "Santa's Village" when acting as a Home button and "View All Menu" when acting as the main menu toggle.aria-expanded: Added dynamic support for thearia-expandedattribute tosanta-button.js. This allows the button to correctly communicate whether the navigation menu is currently collapsed or expanded.ifDefined: ImplementedifDefinedin both the parent and child components. This ensures that accessibility attributes likearia-expandedare completely removed from the DOM when they aren't applicable (e.g., when the button is in "Home" mode), avoiding invalid states.Impacted UI components