Skip to content

reformat codebase using python/black #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StoicLoofah merged 15 commits into from
Jun 29, 2019
Merged

reformat codebase using python/black #87

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7086f7f
reformat codebase using python/black
Jun 26, 2019
06a7958
black -l 80
Jun 26, 2019
ceb4b59
run black --check
Jun 27, 2019
63846f3
mention coding style
Jun 27, 2019
0e41691
just use black without options
Jun 27, 2019
0f2e8e7
run black only on py3
Jun 27, 2019
d71c839
use yaml merge key to define a few special steps for py3
Jun 27, 2019
4a005eb
lists cannot be merged ... my YAML foo is weak :-(
Jun 27, 2019
30723e3
maybe conditions do the trick
Jun 27, 2019
4fceac1
bad old copy & paste
Jun 27, 2019
7e5599e
define a new job, only for style checks
Jun 27, 2019
c9a13e2
fix typo; add link to black editor integration
Jun 27, 2019
8d226e3
merge setup.py
Jun 29, 2019
8d3a59b
blacken setup.py
Jun 29, 2019
bc02625
remove accidentally added test_script
Jun 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
mention coding style
  • Loading branch information
Dominik Neise committed Jun 27, 2019
commit 63846f3ec4d486151f5ba7337f07c329b923c13c
15 changes: 15 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,18 @@ Please submit patches by pull request where possible. Patches should add a test

If you are having trouble running/add/fixing tests for your patch let me know and I'll see if I can help.


Coding Style
==============

We'd like our code to follow PEP8 coding style in this project.
We use [python/black](https://github.com/python/black) in order to make our lives easier.
We propose you do the same within this project, otherwise you might be asked to
reformat your pull requests.

It's really simple just:

pip install black
black .

And there are plug ins for many editors.
Copy link
Collaborator

@cclauss cclauss Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plug ins for many editors

Copy link
Collaborator

@cclauss cclauss Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also "plugins" is a single word (no space).

Copy link
Contributor Author

@dneise dneise Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - done