-
Notifications
You must be signed in to change notification settings - Fork 147
reformat codebase using python/black #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Since black does not exist for Py2, I first decided to verify codestyle only on Py3 (after all the style check is Py version independent). But having conditional steps turned out to be rather hard. In the end I thought: Why not define one dedicated job for all style checks? So now the Style checks are run using py3.7 and for all other Pythons we skip the style checks and only build and run the test suite. |
CONTRIBUTING.md
Outdated
| pip install black | ||
| black . | ||
|
|
||
| And there are plug ins for many editors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also "plugins" is a single word (no space).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - done
|
@cclauss and @StoicLoofah could this be merged? |
|
sorry for being delinquent on merging the other branches, but there are now conflicts to resolve here. @dneise can you take a look at those? Regarding the discussion on documenting and enforcing black, this is exactly what i was hoping for. thanks for integrating those! ... now i need to get black setup myself =) |
|
The precommit hook is the way to go... It blackens the code in the commit process. |
|
@StoicLoofah ok, I think this can be merged now |
|
I am sorry, this PR has a bit of an ugly commit history. Maybe you could to a squash + merge commit? in order to have a cleaner history? After all, the only thing I did in this PR was |
StoicLoofah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Good suggestion on the squash.
I open this PR just to see if the test are still running after reformatting using
python/black