Skip to content

Conversation

@dneise
Copy link
Contributor

@dneise dneise commented Jun 26, 2019

I open this PR just to see if the test are still running after reformatting using python/black

@dneise
Copy link
Contributor Author

dneise commented Jun 27, 2019

Since black does not exist for Py2, I first decided to verify codestyle only on Py3 (after all the style check is Py version independent). But having conditional steps turned out to be rather hard.

In the end I thought:

Why not define one dedicated job for all style checks?

So now the Style checks are run using py3.7 and for all other Pythons we skip the style checks and only build and run the test suite.

CONTRIBUTING.md Outdated
pip install black
black .

And there are plug ins for many editors.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also "plugins" is a single word (no space).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - done

@dneise
Copy link
Contributor Author

dneise commented Jun 28, 2019

@cclauss and @StoicLoofah could this be merged?

@StoicLoofah
Copy link
Collaborator

sorry for being delinquent on merging the other branches, but there are now conflicts to resolve here. @dneise can you take a look at those?

Regarding the discussion on documenting and enforcing black, this is exactly what i was hoping for. thanks for integrating those!

... now i need to get black setup myself =)

@cclauss
Copy link
Collaborator

cclauss commented Jun 28, 2019

The precommit hook is the way to go... It blackens the code in the commit process.

@dneise
Copy link
Contributor Author

dneise commented Jun 29, 2019

@StoicLoofah ok, I think this can be merged now

@dneise
Copy link
Contributor Author

dneise commented Jun 29, 2019

@StoicLoofah

I am sorry, this PR has a bit of an ugly commit history. Maybe you could to a squash + merge commit? in order to have a cleaner history?

After all, the only thing I did in this PR was black . and then figure out how to verify blackness on circleci.

Copy link
Collaborator

@StoicLoofah StoicLoofah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Good suggestion on the squash.

@StoicLoofah StoicLoofah merged commit 6fcd7f6 into ggtracker:upstream Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants