Skip to content

build 64469 support #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2018
Merged

build 64469 support #54

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6905b19
build 64469 support
Apr 27, 2018
1873e6d
test and comment for build 64469
Apr 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test and comment for build 64469
  • Loading branch information
sklett committed Apr 29, 2018
commit 1873e6d6471258339aacc45d5da757e381c44cfb
4 changes: 3 additions & 1 deletion sc2reader/readers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,8 +1877,10 @@ def trigger_ping_event(self, data):
option=data.read_uint32() - 2147483648,
)

class GameEventsReader_64469(GameEventsReader_38749):
class GameEventsReader_64469(GameEventsReader_38996):

# this function is exactly the same as command_event() from GameEventsReader_38996
# with the only change being that flags now has 26 bits instead of 25.
def command_event(self, data):
return dict(
flags=data.read_bits(26),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you leave a comment right here indicating that this is the only change?

Expand Down
Binary file added test_replays/4.3.0.64469/1.SC2Replay
View file
Open in desktop
Binary file not shown.
7 changes: 7 additions & 0 deletions test_replays/test_all.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,13 @@ def test_59587(self):
factory = sc2reader.factories.SC2Factory()
replay = factory.load_replay(replayfilename)

def test_64469(self):
for replayfilename in [
"test_replays/4.3.0.64469/1.SC2Replay",
]:
factory = sc2reader.factories.SC2Factory()
replay = factory.load_replay(replayfilename)


class TestGameEngine(unittest.TestCase):
class TestEvent(object):
Expand Down