Merged
Conversation
StoicLoofah
requested changes
Apr 28, 2018
Collaborator
StoicLoofah
left a comment
StoicLoofah
left a comment
There was a problem hiding this comment.
The PR looks good! Thanks for all of the iteration on getting this put together.
In addition to the comments, can you also add a test for this? It should look pretty much like
sc2reader/test_replays/test_all.py
Lines 557 to 562 in 080e09d
Presumably the test replay should be uploaded to a new folder 4.3.0.64469.
sc2reader/readers.py
Outdated
| option=data.read_uint32() - 2147483648, | ||
| ) | ||
|
|
||
| class GameEventsReader_64469(GameEventsReader_38749): |
Collaborator
There was a problem hiding this comment.
This should inherit from GameEventsReader_38996
|
|
||
| def command_event(self, data): | ||
| return dict( | ||
| flags=data.read_bits(26), |
Collaborator
There was a problem hiding this comment.
can you leave a comment right here indicating that this is the only change?
StoicLoofah
approved these changes
Apr 29, 2018
Collaborator
StoicLoofah
left a comment
StoicLoofah
left a comment
There was a problem hiding this comment.
Looks great. Thanks for the fix and working through all of the feedback!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.