Skip to content

Add a link to the Circle CI test results #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StoicLoofah merged 2 commits into from
Apr 23, 2018
Merged

Add a link to the Circle CI test results #50

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a3c0ed
Add a link to the Circle CI test results
Apr 21, 2018
cd3241d
Correct url
Apr 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add a link to the Circle CI test results
  • Loading branch information
cclauss authored Apr 21, 2018
commit 5a3c0edbf3333cbc429f9fe87e51a58bc22228aa
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ If you can't share your code/replays publicly try to replicate with a smaller sc
Patches
=========

Please submit patches by pull request where possible. Patches should add a test to confirm their fix and should not break previously working tests.
Please submit patches by pull request where possible. Patches should add a test to confirm their fix and should not break previously working tests. Circle CI automatically runs tests on each pull request so please check https://circleci.com/gh/ggtracker to see the results of those tests.
Copy link
Collaborator

@StoicLoofah StoicLoofah Apr 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the link should be https://circleci.com/gh/ggtracker/sc2reader , not https://circleci.com/gh/ggtracker . I actually can't access the latter link


If you are having trouble running/add/fixing tests for your patch let me know and I'll see if I can help.