Add a link to the Circle CI test results #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StoicLoofah
requested changes
Apr 21, 2018
CONTRIBUTING.md
Outdated
| @@ -14,7 +14,7 @@ If you can't share your code/replays publicly try to replicate with a smaller sc | |||
| Patches | |||
| ========= | |||
|
|
|||
| Please submit patches by pull request where possible. Patches should add a test to confirm their fix and should not break previously working tests. | |||
| Please submit patches by pull request where possible. Patches should add a test to confirm their fix and should not break previously working tests. Circle CI automatically runs tests on each pull request so please check https://circleci.com/gh/ggtracker to see the results of those tests. | |||
There was a problem hiding this comment.
I believe the link should be https://circleci.com/gh/ggtracker/sc2reader , not https://circleci.com/gh/ggtracker . I actually can't access the latter link
StoicLoofah
approved these changes
Apr 23, 2018
|
Thanks for all of your work on CI! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.