Skip to content

Split lines of text with str.splitlines() #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 18, 2025
Merged

Split lines of text with str.splitlines() #206

merged 3 commits into from
Jan 18, 2025

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented Jan 17, 2025 •
edited
Loading

@manuelseeger
Copy link
Contributor

Thanks for the PR :)

StoicLoofah
StoicLoofah approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@StoicLoofah StoicLoofah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@StoicLoofah StoicLoofah merged commit 58a8070 into ggtracker:upstream Jan 18, 2025
2 checks passed
@cclauss cclauss deleted the use-str.splitlines branch January 18, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StoicLoofah StoicLoofah StoicLoofah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting trailing '\r' on some but not all ability_names in game_events
3 participants
@cclauss @manuelseeger @StoicLoofah