Getting trailing '\r' on some but not all ability_names in game_events

[manuelseeger]

Examples include:

ability_name = 'TrainQueen\r'
ability_name = 'ChronoBoostEnergyCost\r'
ability_name = 'CausticSpray\r'

Where others look fine:
ability_name = 'TrainProbe'

This is with a fresh copy of sc2reader from GitHub and

import sc2reader

replay = sc2reader.load_replay('Radhuset Station LE (85) ZvP chrono.SC2Replay')

a = [e for e in replay.game_events if hasattr(e, 'ability_name') and '\r' in e.ability_name]

print(a) # 137 results

I could work around it with my own engine plugin but would be nice if this is fixed since it also breaks downstream apps like SpawningTool.

class EventAbilityNameCorrector(BasePlugin):
    name = "EventAbilityCorrector"

    def handleEvent(self, e: Event, replay: RawReplay):
        if hasattr(e, "ability_name") and "\r" in e.ability_name:
            e.ability_name = e.ability_name.replace("\r", "")

[cclauss]

This is caused by the difference between Windows line endings and rest-of-the-world line endings.

        if "\r" in  getattr(e, "ability_name", ""):
            e.ability_name = e.ability_name.strip()

[manuelseeger]

Sure, but should still be fixed in upstream right?

I had a quick look and I guess this line and the next is missing a strip() ?

sc2reader/sc2reader/data/__init__.py

Line 22 in 46629e5

str_id, abilities = entry.split(",", 1)

[cclauss]

Are you willing to create a pull request with tests that implements:

    str_id, *abilities = entry.strip().split(",")
    ABIL_LOOKUP[str_id] = abilities