Skip to content

Feat: allow Observer.url #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StoicLoofah merged 2 commits into from
Sep 1, 2023
Merged

Feat: allow Observer.url #189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97b101e
feat: add region_id attr to Entity
NumberPigeon Aug 30, 2023
f967828
refactor: reuse region_id
NumberPigeon Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sc2reader/objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,11 @@ def __init__(self, sid, slot_data):
toon_handle = self.toon_handle or "0-S2-0-0"
parts = toon_handle.split("-")

#: The Battle.net region id the entity is registered to
self.region_id = int(parts[0])

#: The Battle.net region the entity is registered to
self.region = GATEWAY_LOOKUP[int(parts[0])]
self.region = GATEWAY_LOOKUP[self.region_id]

#: The Battle.net subregion the entity is registered to
self.subregion = int(parts[2])
Expand Down