Skip to content

Conversation

@NumberPigeon
Copy link
Contributor

Before this commit:

>>> o
Observer 4 - EnObsB
>>> o.url
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/daydrm/CodePlayground/python/sc2reader/sc2reader/objects.py", line 293, in url
    return self.URL_TEMPLATE.format(
           ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'region_id'

After this commit:

>>> o = r.observer[4]
>>> o.url
'https://starcraft2.com/en-us/profile/2/1/10400173'

Co-authored-by: Christian Clauss <[email protected]>
@StoicLoofah StoicLoofah merged commit f3744fe into ggtracker:upstream Sep 1, 2023
@NumberPigeon NumberPigeon deleted the Observer-url branch September 4, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants