Skip to content

Context.py event attribute fixes #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StoicLoofah merged 3 commits into from
Aug 20, 2022
Merged

Context.py event attribute fixes #177

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6acc9e1
adjust attribute to reflect whats being checked
Andrene Aug 7, 2022
c4dd5da
unit_index isnt an attribute of an event its a var
Andrene Aug 7, 2022
310cb1d
change value to better reflect logged error
Andrene Aug 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sc2reader/engine/plugins/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def handleUnitDiedEvent(self, event, replay):
else:
self.logger.error(
"Unable to delete unit index {} at {} [{}], index not active.".format(
event.killer_pid, Length(seconds=event.second), event.frame
event.unit_id_index, Length(seconds=event.second), event.frame
)
)
else:
Expand Down Expand Up @@ -307,7 +307,7 @@ def handleUnitDoneEvent(self, event, replay):
else:
self.logger.error(
"Unit {} done at {} [{}] before it was started!".format(
event.killer_pid, Length(seconds=event.second), event.frame
event.unit_id, Length(seconds=event.second), event.frame
)
)

Expand All @@ -323,7 +323,7 @@ def handleUnitPositionsEvent(self, event, replay):
else:
self.logger.error(
"Unit at active_unit index {} moved at {} [{}] but it doesn't exist!".format(
event.killer_pid, Length(seconds=event.second), event.frame
unit_index, Length(seconds=event.second), event.frame
)
)

Expand Down