Context.py event attribute fixes#177
Merged
StoicLoofah merged 3 commits intoggtracker:upstreamfrom Aug 20, 2022
Andrene:upstream
Merged
Context.py event attribute fixes#177StoicLoofah merged 3 commits intoggtracker:upstreamfrom Andrene:upstream
StoicLoofah merged 3 commits intoggtracker:upstreamfrom
Andrene:upstream
Conversation
Collaborator
|
Why not |
Contributor
Author
|
The changes I made were to handleUnitPositionsEvent and handleUnitDoneEvent, neither of the associated events processed by those have either attribute. In the above commit I fixed the reference here sc2reader/sc2reader/engine/plugins/context.py Line 201 in c17bd35 Further down in the handleUnitDiedEvent function an error for unknown killing player id exists and uses the appropriate non-deprecated attribute sc2reader/sc2reader/engine/plugins/context.py Line 219 in c17bd35 |
StoicLoofah
approved these changes
Aug 20, 2022
Collaborator
StoicLoofah
left a comment
There was a problem hiding this comment.
Looks good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix issue #176