Skip to content

Skip updating the owner on an event with no unit #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StoicLoofah merged 1 commit into from
Dec 11, 2020
Merged

Skip updating the owner on an event with no unit #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Skip updating the owner on an event with no unit
  • Loading branch information
@StoicLoofah
StoicLoofah committed Oct 26, 2020
commit 4c577d6ab9022fe2872e700b49f03fa6ebac46f9
2 changes: 1 addition & 1 deletion sc2reader/engine/plugins/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ def handleUnitOwnerChangeEvent(self, event, replay):
)
)

if event.unit_upkeeper:
if event.unit_upkeeper and event.unit:
if event.unit.owner:
event.unit.owner.units.remove(event.unit)
event.unit.owner = event.unit_upkeeper
Expand Down