Skip to content

Skip updating the owner on an event with no unit#133

Merged
StoicLoofah merged 1 commit intoggtracker:upstreamfrom
StoicLoofah:missing_owner_upkeep
Dec 11, 2020
Merged

Skip updating the owner on an event with no unit#133
StoicLoofah merged 1 commit intoggtracker:upstreamfrom
StoicLoofah:missing_owner_upkeep

Conversation

@StoicLoofah
Copy link
Collaborator

On this replay, I was getting this error:

>>> sc2reader.load_replay('nounit.SC2Replay')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/kevin/sc2reader/sc2reader/factories/sc2factory.py", line 88, in load_replay
    return self.load(Replay, source, options, **new_options)
  File "/home/kevin/sc2reader/sc2reader/factories/sc2factory.py", line 166, in load
    return self._load(cls, resource, filename=filename, options=options)
  File "/home/kevin/sc2reader/sc2reader/factories/sc2factory.py", line 175, in _load
    obj = cls(resource, filename=filename, factory=self, **options)
  File "/home/kevin/sc2reader/sc2reader/resources.py", line 346, in __init__
    engine.run(self)
  File "/home/kevin/sc2reader/sc2reader/engine/engine.py", line 179, in run
    for new_event in event_handler(event, replay) or []:
  File "/home/kevin/sc2reader/sc2reader/engine/plugins/context.py", line 254, in handleUnitOwnerChangeEvent
    if event.unit.owner:
AttributeError: 'NoneType' object has no attribute 'owner'

Seemed liked a relatively straightforward change to bypass this block if there is no unit

@StoicLoofah StoicLoofah merged commit 6931aaa into ggtracker:upstream Dec 11, 2020
@StoicLoofah StoicLoofah deleted the missing_owner_upkeep branch December 11, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant