Skip to content

Handle missing attributes #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 6, 2020
Merged

Handle missing attributes #129

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b942fe3
some attributes
StoicLoofah Sep 29, 2020
c9338cf
handle missing value
StoicLoofah Sep 29, 2020
2f4c89a
more co-op data
StoicLoofah Sep 29, 2020
7b08c1e
fix black
StoicLoofah Sep 29, 2020
ba6817d
fix tests
StoicLoofah Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
handle missing value
  • Loading branch information
@StoicLoofah
StoicLoofah committed Sep 29, 2020
commit c9338cf6125ad4b545287a06ccaecd9998ef8065
6 changes: 5 additions & 1 deletion sc2reader/objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,11 @@ def __init__(self, header, attr_id, player, value):
self.value = None
else:
self.name, lookup = LOBBY_PROPERTIES[self.id]
self.value = lookup[value.strip("\x00 ")[::-1]]
try:
self.value = lookup[value.strip("\x00 ")[::-1]]
except KeyError:
self.logger.info("Missing attribute value: {0}".format(value))
self.value = None

def __repr__(self):
return str(self)
Expand Down