Handle missing attributes#129
Merged
StoicLoofah merged 5 commits intoggtracker:upstreamfrom Oct 6, 2020
Merged
Conversation
Collaborator
Author
|
I figured out my mistake: I played the co-op game but didn't open the Game Summary from my Match History. I was able to get a bunch more data in there. However, it does appear that I'll need to play with all of the commanders to make sure I cover my bases, so I'll get on that soon. |
Collaborator
Author
|
I played a game with all commanders and opened up the score screens and didn't add any more entries, so hopefully this is sufficient |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #126. I used https://github.com/ggtracker/sc2reader/blob/e22cb674ad148de53e32775681a9c097c79766e6/sc2reader/scripts/sc2attributes.py to generate a new
attributes.json, but it actually still didn't get the values we needed, so I just caught theKeyErrorif it is missing.