Conversation
api/src/domain/inputs/domain-tag.js
Outdated
| description: '', | ||
| fields: () => ({ | ||
| en: { | ||
| type: GraphQLString, |
There was a problem hiding this comment.
Maybe make non-nullable?
api/src/domain/inputs/domain-tag.js
Outdated
| description: 'The English translation of the label.', | ||
| }, | ||
| fr: { | ||
| type: GraphQLString, |
| let tags | ||
| if (typeof args.tags !== 'undefined') { | ||
| tags = args.tags | ||
| } else { | ||
| tags = [] | ||
| } | ||
|
|
There was a problem hiding this comment.
This defaults tags to an empty array but the updateDomain mutation defaults tags to null
|
|
||
| let tags | ||
| if (typeof args.tags !== 'undefined') { | ||
| tags = args.tags |
There was a problem hiding this comment.
Should probably cleanse input to be safe
|
|
||
| let tags | ||
| if (typeof args.tags !== 'undefined') { | ||
| tags = args.tags |
There was a problem hiding this comment.
Should probably cleanse input to be safe
| borderWidth="1px" | ||
| borderColor="gray.900" | ||
| > | ||
| <TagLabel mx="auto">{label[locale]}</TagLabel> |
There was a problem hiding this comment.
locale not required if handled at loader.
| ) | ||
| } | ||
| AdminDomainCard.propTypes = { url: string } | ||
| AdminDomainCard.propTypes = { url: string, tags: array, locale: string } |
There was a problem hiding this comment.
locale not required if handled at loader.
frontend/src/domains/DomainCard.js
Outdated
| borderWidth="1px" | ||
| borderColor="gray.900" | ||
| > | ||
| <TagLabel mx="auto">{label[i18n.locale]}</TagLabel> |
There was a problem hiding this comment.
locale not required if handled at loader.
frontend/src/graphql/queries.js
Outdated
| claimTags { | ||
| label { | ||
| en | ||
| fr | ||
| } | ||
| } |
There was a problem hiding this comment.
claimTags if translation handled at loader.
frontend/src/graphql/queries.js
Outdated
| claimTags { | ||
| label { | ||
| en | ||
| fr | ||
| } | ||
| } |
There was a problem hiding this comment.
claimTags if translation handled at loader.
2 participants
Admins can now add pre-determined tag labels to each domain in their organization, which are displayed on the organization details page, and the admin page
Org Details Page:
Admin Page:
closes #3667