Skip to content

Fix DMARC Summary Report Pagination#2061

Merged
ThomasNickerson merged 6 commits intomasterfrom
fe-fix-dmarc-summary-pagination
Apr 13, 2021
Merged

Fix DMARC Summary Report Pagination#2061
ThomasNickerson merged 6 commits intomasterfrom
fe-fix-dmarc-summary-pagination

Conversation

@ThomasNickerson
Copy link
Copy Markdown
Contributor

This PR fixes the bug described in #2050 by switching the DMARC Summary table to using the newer findMyDmarcSummaries query instead of findMyDomains. It also refactors DmarcReportTable.js to pull pagination code out into its parent component, which requires less code, behaves more predictably, and is more maintainable.

It additionally:

  • Makes it so pagination controls are displayed even if the "no messages" error replaces the DMARC report table
    • This will reduce the severity of the issue mentioned above should it reoccur by not requiring a reload to see the table
  • updates relevant test fixtures
  • changes page size options elsewhere to be more consistent

Closes #2050.

@ThomasNickerson ThomasNickerson merged commit c92c889 into master Apr 13, 2021
@ThomasNickerson ThomasNickerson deleted the fe-fix-dmarc-summary-pagination branch April 13, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible to go past end of DMARC Report table when clicking next

2 participants