Chore: Handle APP_URL with subpath correctly #2634
Closed
+62
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
If the user does not have the
APP_URLset after this fix it will redirect them tohttp://localhost📃 Description
This PR makes sure that we handle
APP_URLwith subpaths better.closes #2596
Docs Update: alexjustesen/speedtest-tracker-docs#105
🪵 Changelog
✏️ Changed
APP_URLvariable when generating urls inside the application❔ Tests
This PR was tests with the added test cases.
As well manual with the following NGINX config
NGINX Config
Both the in App notifications and in all the requests the correct URL is used.