This repository was archived by the owner on Oct 16, 2025. It is now read-only.
Standardize repo (minus tests)#97
Merged
Merged
Conversation
mcmire
force-pushed
the
standardize
branch
3 times, most recently
from
c017cc6 to
e0ec0bb
Compare
Merged
* Add missing workflows from template repo * Replace `.gitattributes`, `.editorconfig`, `.gitignore` with version from template repo * Add NPM scripts in template repo but missing here * Add `allow-scripts` and run it via `yarn setup` * Update TypeScript config to match template repo * Exclude test files * Use ES2020 `.d.ts` instead of ES2017 * Upgrade Node to v14 * Lint JSON files with `eslint-plugin-packagejson` instead of `prettier-plugin-json` * Update README to match template repo * Update and backfill changelog
Gudahtt
reviewed
Apr 14, 2022
Gudahtt
suggested changes
Apr 14, 2022
Gudahtt
left a comment
Gudahtt
left a comment
Member
There was a problem hiding this comment.
Mostly looks good! Only issue I saw was the CI build-test Node.js version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitattributes,.editorconfig,.gitignorewith versionfrom template repo
allow-scriptsand run it viayarn setup.d.tsinstead of ES2017eslint-plugin-packagejsoninstead ofprettier-plugin-json