This repository was archived by the owner on Oct 16, 2025. It is now read-only.
Update dev dependencies#96
Merged
Merged
Conversation
* Use latest version of `@metamask/eslint-config`; add accompanying
packages
* Add `.prettierrc` from module template, as we now require it
* Fix linting issues caused by these changes
* Bump TypeScript to 4.4.x (no accompanying changes needed)
* Bump `tape` from ^4.9.0 to ^5.5.3
* Remove redundant `t.end()` from async tests, which are causing
errors. According to the `tape` README:
> If `cb` returns a Promise, it will be implicitly awaited. If that
> promise rejects, the test will be failed; if it fulfills, the test
> will end. Explicitly calling `t.end()` while also returning a
> Promise that fulfills is an error.
Gudahtt
reviewed
Apr 12, 2022
| ], | ||
| files: ['*.js'], | ||
| parserOptions: { | ||
| sourceType: 'script', |
Member
There was a problem hiding this comment.
Do we need this? Our ESLint Node.js config has this comment:
// The recommended Node.js plugin config sets the correct
sourceTypeper the
//typefield of the local package.json file, so we don't set that here.
That implies to me that we don't need to set this explicitly.
Contributor
Author
There was a problem hiding this comment.
You're right. Good call. Removed accordingly in 6abe742.
Member
There was a problem hiding this comment.
This was probably taken from the module template? Looks like the same mistake is made there as well
Contributor
Author
There was a problem hiding this comment.
Yup! Okay, I'll make a change there as well.
Gudahtt
reviewed
Apr 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@metamask/eslint-config; add accompanyingpackages
.prettierrcfrom module template, as we now require ittapefrom ^4.9.0 to ^5.5.3t.end()from async tests, which are causingerrors. According to the
tapeREADME: