Closed
Conversation
reason of creating a base_url cause it was assigned hardcoded in scripts and it is better to set hardcoded variables seperately in a class thus created a new baseurl
files that are being used for baseurls.py
Why I did it? I have used the factory design pattern to do my creational pattern where i had to provide an interface for creating objects in superclass, but allowing subclasses to alter the type of objects that will be created. How i did it? I created a new interface class for location to implement creational pattern and the interface for location class is missing so i just added an interface class and serialized the location into a dict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it?
Within the Structural Patterns I decided to use Adapter Design Method to allow objects with incompatible interfaces to collaborate
How I did it?
I Created a Replica of location class because serializer function has different behavior for CSBS LOCATION Class thus we created a class Location adapter "making changes in "init_py"
and using the Csbs.py i had to update serializer response and removed it from csbslocation class.