Create baseurls.py #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reason of creating a base_url cause it was assigned hardcoded in scripts and it is better to set hardcoded variables seperately in a class thus created a new baseurl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reason of creating a base_url cause it was assigned hardcoded in scripts and it is better to set hardcoded variables seperately in a class thus created a new baseurl and mades changes to the csbs.py which is also attached where i imported newly created class and got the base url for csbs from the baseurl class and finally i used jhu.py where i import newly created class and get the base url for jhu from baseurl class and using nyt.py same changes were made but in line#39 got the base url for nyt from baseUrl class.