Skip to content

Introduce the Factory pattern via LocationServiceFactory as a way to … #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hughie-coles wants to merge 2 commits into from
Closed

Introduce the Factory pattern via LocationServiceFactory as a way to … #465

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b2cb2e
Introduce the Factory pattern via LocationServiceFactory as a way to …
hughie-coles Aug 15, 2021
997ed85
add constants for each data source to remove magic strings
hughie-coles Aug 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add constants for each data source to remove magic strings
  • Loading branch information
@hughie-coles
hughie-coles committed Aug 15, 2021
commit 997ed85dcffe4f24af2a3aba629f123176bf8d1d
11 changes: 8 additions & 3 deletions app/services/location/locationservicefactory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,17 @@
from ..location.nyt import NYTLocationService


NEW_YORK_TIMES = 'nyt'
JOHNS_HOPKINS_UNIVERSITY = 'jhu'
CSBS = 'csbs'


class LocationServiceFactory:
def create(location_service_name):
lowercase_service_name = location_service_name.lower()
if lowercase_service_name == 'csbs':
if lowercase_service_name == CSBS:
return CSBSLocationService()
elif lowercase_service_name == 'jhu':
elif lowercase_service_name == JOHNS_HOPKINS_UNIVERSITY:
return JhuLocationService()
elif lowercase_service_name == 'nyt':
elif lowercase_service_name == NEW_YORK_TIMES:
return NYTLocationService()