Introduce the Factory pattern via LocationServiceFactory as a way to …#465
Closed
hughie-coles wants to merge 2 commits intoExpDev07:masterfrom
Closed
Introduce the Factory pattern via LocationServiceFactory as a way to …#465hughie-coles wants to merge 2 commits intoExpDev07:masterfrom
hughie-coles wants to merge 2 commits intoExpDev07:masterfrom
Conversation
…create new LocationServices in an extensible way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am introducing a LocationServiceFactory to abstract the creation of different LocationServices. Each location has a name associated, and we use this as the key for each instance.
Data sources can come and go (or existing ones can change). This makes the LocationService a part of the code that is subject to change. By abstracting the creation of these services, we enable the addition and changing of the list of data sources