Merged
Conversation
GabrielDS
force-pushed
the
enhancement_issue_251
branch
from
28c43c8 to
b7be144
Compare
Kilo59
reviewed
Apr 2, 2020
docker-compose.yml
Outdated
| build: . | ||
| image: expdev07/coronavirus-tracker-api:2.0 | ||
| restart: always | ||
| command: pipenv --python 3.7 run dev |
Collaborator
There was a problem hiding this comment.
We shouldn't be running the dev version with the "reload" flag in the container.
Kilo59
reviewed
Apr 2, 2020
Pipfile
Outdated
|
|
||
| [scripts] | ||
| dev = "uvicorn app.main:APP --reload" | ||
| dev = "uvicorn --host 0.0.0.0 app.main:APP --reload" |
Collaborator
There was a problem hiding this comment.
You shouldn't be changing this.
GabrielDS
force-pushed
the
enhancement_issue_251
branch
from
b7be144 to
d4d7d2d
Compare
Kilo59
added
dev
Kilo59
reviewed
Apr 3, 2020
Dockerfile
Outdated
|
|
||
| # INSTALL DEPENDENCIES | ||
| RUN pip install pipenv | ||
| RUN pipenv install --system --deploy --dev |
Collaborator
There was a problem hiding this comment.
We should install from the requirements files once this goes in. #245
Contributor
Author
There was a problem hiding this comment.
Which requirements file? requirements-dev.txt or requirements.txt?
GabrielDS
force-pushed
the
enhancement_issue_251
branch
from
d4d7d2d to
5b0631e
Compare
GabrielDS
force-pushed
the
enhancement_issue_251
branch
from
5b0631e to
4ffe433
Compare
Kilo59
approved these changes
Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
The pipenv is slow down the image build, also, increase ~37mb of image's size but this pull request is just to add docker flow for development enviroment. To run on production enviroments safety, we will need to do somes ajusts that could change the project a little bit.
The app waits a environment variable called "PORT" but, even without it, i can run the api using the port 8000 (a little bit strange).
#252