Skip to content

Add continent code(s) assignment #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bost wants to merge 7 commits into from
Closed

Add continent code(s) assignment #226

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f6640cb
assert_equal: formatted json-strings make debugging easier
BostX Mar 26, 2020
0ca8f68
Readable json test files
BostX Mar 27, 2020
937648e
Add continent code(s) assignment
BostX Mar 26, 2020
336c2e4
Document continent_codes_list in the README.md
BostX Mar 26, 2020
a6094ff
Fix formatting and import order
BostX Mar 27, 2020
09e02b5
Fix continent codes form a set. Not a list
BostX Mar 28, 2020
ee02187
Egypt is located in Africa and also in Asia
BostX Mar 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Document continent_codes_list in the README.md
  • Loading branch information
@BostX
BostX committed Mar 29, 2020
commit 336c2e419b8bf28a36f825e9c296a390fd7580f1
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ __Sample response__
"id": 39,
"country": "Norway",
"country_code": "NO",
"continent_codes_list": ["EUR"],
"country_population": 5009150,
"province": "",
"county": "",
Expand Down Expand Up @@ -175,6 +176,7 @@ __Sample response__
"id": 0,
"country": "Thailand",
"country_code": "TH",
"continent_codes_list": ["ASI"],
"country_population": 67089500,
"province": "",
"county": "",
Expand All @@ -192,6 +194,7 @@ __Sample response__
{
"id": 39,
"country": "Norway",
"continent_codes_list": ["EUR"],
"country_code": "NO",
"province": "",
"county": "",
Expand Down Expand Up @@ -254,6 +257,7 @@ __Sample Response__
"id": 16,
"country": "Italy",
"country_code": "IT",
"continent_codes_list": ["EUR"],
"country_population": 60340328,
"province": "",
"county": "",
Expand Down Expand Up @@ -294,6 +298,7 @@ __Sample Response__
"id": 0,
"country": "US",
"country_code": "US",
"continent_codes_list": ["NAC"],
"country_population": 310232863,
"province": "New York",
"state": "New York",
Expand All @@ -313,6 +318,7 @@ __Sample Response__
"id": 1,
"country": "US",
"country_code": "US",
"continent_codes_list": ["NAC"],
"country_population": 310232863,
"province": "New York",
"state": "New York",
Expand Down