Skip to content

Conversation

@Bost
Copy link
Contributor

@Bost Bost commented Mar 28, 2020

Please pull. (And please note: continent codes form a set, not a list.)

@Bost
Copy link
Contributor Author

Bost commented Mar 30, 2020

I just discovered the list of transcontinental countries. It's just getting more and more complicated, hmm :( Quite a few corrections has to be done in my PR and also in the datafile on wikipedia)

Another idea: Instead of serving a set of continent codes we can serve a primitive value - just one continent code, by creating "unions" of continents. i.e. if we extend the continent-dictionary by:

    "Eurasia"  : "EUAS",  # Russia
    "Afroasia" : "AFAS",  # Egypt - the only country so far
    "Oceasia"  : "OCAS",  # Indonesia
    "Americas" : "AMER",  # Panama
    # etc.

Let me edit the PR and explore this new idea.

@Bost Bost closed this Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants