No locations data 404#192
Merged
Merged
Conversation
Kilo59
force-pushed
the
no-locations-data-404
branch
from
March 26, 2020 02:18
7283815 to
0368880
Compare
Owner
|
tests |
Kilo59
force-pushed
the
no-locations-data-404
branch
from
March 26, 2020 02:25
0368880 to
d464351
Compare
Collaborator
Author
fixed the tests |
ExpDev07
approved these changes
Mar 26, 2020
| locations = [location for location in locations if str(getattr(location, key)).lower() == str(value)] | ||
| except AttributeError: | ||
| pass | ||
| if not locations: |
Owner
There was a problem hiding this comment.
Shouldn't this be moved outside of the loop?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #179