404 for missing location data

Author: Kilo59

app/router/locations.py

@@ -39,6 +39,8 @@ def get_locations(
             locations = [location for location in locations if str(getattr(location, key)).lower() == str(value)]
         except AttributeError:
             pass
+        if not locations:
+            raise HTTPException(404, detail=f"Source `{source}` does not have the desired location data.")
 
     # Return final serialized data.
     return {

tests/test_routes.py

@@ -129,7 +129,7 @@ def tearDown(self):
         ({"timelines": 1}, 200),
         ({"source": "jhu", "timelines": True}, 200),
         ({"source": "csbs", "country_code": "US"}, 200),
-        ({"source": "jhu", "country_code": "US"}, 404)
+        ({"source": "jhu", "country_code": "US"}, 404),
     ],
 )
 def test_locations_status_code(api_client, query_params, expected_status):
@@ -138,6 +138,7 @@ def test_locations_status_code(api_client, query_params, expected_status):
     print(f"\tjson:\n{pf(response.json())[:1000]}\n\t...")
     assert response.status_code == expected_status
 
+
 @pytest.mark.parametrize(
     "query_params",
     [