-
-
Notifications
You must be signed in to change notification settings - Fork 314
Make Population a Property of Location Object #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
90c0fd8
adds .DS_Store to .gitignore for OSX devs
Turreted 14101de
adds country_in_database function to countrycodes
Turreted 4325aaa
adds population as property of the location object
Turreted 36963da
change population property to country_population
Turreted 47a2fba
Move countrypopulation to utils
Turreted a0f8169
Avoid plagiarism
Turreted 4de23fa
Allow for country_population to be added to all locations as long as …
ExpDev07 2e0034e
^
ExpDev07 8add335
Merge remote-tracking branch 'upstream/master'
73f02fb
change datasource + refactoring + add to documentation
6c29742
remove comment
ExpDev07 80daa5a
fix tests
dfbce99
now fixed tests
7a03f77
now tests work :P
6d664f5
now tests work
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,4 +63,7 @@ coverage.xml | |
| docs/_build/ | ||
|
|
||
| # PyBuilder | ||
| target/ | ||
| target/ | ||
|
|
||
| # OSX Stuff | ||
| .DS_Store | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| import requests | ||
| from io import StringIO, BytesIO | ||
| from cachetools import cached, TTLCache | ||
| from zipfile import ZipFile, ZipInfo | ||
| from .countrycodes import country_code | ||
|
|
||
| # Fetching of the populations. | ||
| def fetch_populations(): | ||
| """ | ||
| Returns a dictionary containing the population of each country fetched from the GeoNames (https://www.geonames.org/). | ||
|
|
||
| :returns: The mapping of populations. | ||
| :rtype: dict | ||
| """ | ||
| print ("Fetching populations...") | ||
|
|
||
| # Mapping of populations | ||
| mappings = {} | ||
|
|
||
| # Fetch the countries. | ||
| countries = requests.get("http://api.geonames.org/countryInfoJSON?username=dperic").json()['geonames'] | ||
|
|
||
| # Go through all the countries and perform the mapping. | ||
| for country in countries: | ||
| mappings.update({ country["countryCode"]: int(country["population"]) or None }) | ||
|
|
||
| # Finally, return the mappings. | ||
| return mappings | ||
|
|
||
| # Mapping of alpha-2 codes country codes to population. | ||
| populations = fetch_populations() | ||
|
|
||
| # Retrieving. | ||
| def country_population(country_code, default=None): | ||
| """ | ||
| Fetches the population of the country with the provided country code. | ||
|
|
||
| :returns: The population. | ||
| :rtype: int | ||
| """ | ||
| return populations.get(country_code, default) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could make this a "start_up event"
https://fastapi.tiangolo.com/advanced/events/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it seems to work on startup now though? @Kilo59
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely, what you have here looks like it would work fine. Just pointing out a feature of FastAPI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kilo59 alright :) We can look at it later. Now populations should work all perfectly. That's a nice feature.