Make Population a Property of Location Object

[Turreted]

Note that this only works for countries, and will return None is a province is specified. Also note that this does not add anything to that API, It simply extends the location object.
All data is pulled from the World Bank, and can be found Here

[ExpDev07]

Nice work. Just throwing this out there: would it perhaps be better to name the property country_population, meaning people can access it in every location, but it's explicitly marked that it belongs to the country?

Also, I think you should move the countrypopulation method over to /utils, perhaps under /utils/population? Still keep the caching mechanism though.

[Turreted]

Should be good to go!

I can't test everything locally (pipenv's being annoying), so if you might want to verify that everything works as intended before merging

[ExpDev07]

Thanks for this! I'll look over it and merge.

[Turreted]

Is this ready to merge or are there more changes that I should make?

[ExpDev07]

@Turreted hey, while testing, your initial data-source was missing populations for a bunch of countries, so I decided to look for another one. I opted with https://www.geonames.org/ and they seem to provide relatively updated populations as well as for every country we currently have.

The populations are now also fetched when starting the app. There's no point of having a refresh cache mechanism on it as it probably doesn't update very often so, so it's fine to just retrieve the data on startup instead.

Looks good to go now.

[Kilo59]

You could make this a "start_up event"
https://fastapi.tiangolo.com/advanced/events/

[ExpDev07]

Hmm, it seems to work on startup now though? @Kilo59

[Kilo59]

Absolutely, what you have here looks like it would work fine. Just pointing out a feature of FastAPI.

[ExpDev07]

@Kilo59 alright :) We can look at it later. Now populations should work all perfectly. That's a nice feature.

[ExpDev07]

@all-contributors please add @Turreted for code.

[allcontributors]

@ExpDev07

I've put up a pull request to add @Turreted! 🎉