Skip to content

Conversation

@Bost
Copy link
Contributor

@Bost Bost commented Mar 25, 2020

I'm sending you a PR just to show some progress, so it's more of a Request For Comments than a PR.

Most important is the TODO at the end of the countrycodes.py. In addition to that I also should think about proper initialization of the continent_codes_list. Which one (of the following) should it be?

   continent_codes_list: list = None,
   continent_codes_list: list = [],
   continent_codes_list: list = continents.default_continent_codes_list,

And also I've noticed you require test cases and such... uuh, ooh. And maybe a bit of documentation (in the README.md or somewhere else) won't hurt neither... ooh, eeh.

@ExpDev07
Copy link
Owner

Looks good ! Just need to sort the test cases :)

@Bost Bost mentioned this pull request Mar 27, 2020
@Bost
Copy link
Contributor Author

Bost commented Mar 27, 2020

Still just a work-in-progress (backing up my work)

@Bost Bost closed this Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants