wip: Add continent codes #180
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sending you a PR just to show some progress, so it's more of a Request For Comments than a PR.
Most important is the TODO at the end of the
countrycodes.py. In addition to that I also should think about proper initialization of thecontinent_codes_list. Which one (of the following) should it be?And also I've noticed you require test cases and such... uuh, ooh. And maybe a bit of documentation (in the README.md or somewhere else) won't hurt neither... ooh, eeh.