Skip to content

Adding continent codes? #73

@Bost

Description

@Bost

If there's a need I could implement 3-letter continent codes:

"coordinates" : "{…}"
"country" : "Thailand"
"country_code" : "TH" 
"continent" : "ASI"      <---- new

The main complications are:

  • I couldn't find any appropriate ISO norm so the codes are defined by me:
  {
   "Africa"        "AFR"
   "North America" "NAC"  ;; NAM clashes with "Namibia"
   "Oceania"       "OCE"
   "Antarctica"    "ANA"  ;; ANT clashes with "Netherlands Antilles"
   "Asia"          "ASI"
   "Europe"        "EUR"
   "South America" "SAC"
   d/others        d/default-continent-code ;; i.e. "CCC"
   }
  • How to assign countries on multiple continents. E.g. Russia, Turkey, etc are in Asia or Europe?
  • The cruise ships - I'd assign them to the default-continent-code i.e. to a non-existing continent.
  • Performance(?) - IMO it is essential to keep the service fast and smal (few bytes).

What do you think about that?

I'm trying to work out all the problems at first in clojure in my own project, on the branch continents.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions