added docker build/run #123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExpDev07
requested changes
Mar 21, 2020
Owner
There was a problem hiding this comment.
Hey, thanks! But a couple of things:
- Please add your .idea/ IDE folder to gitignore and remove them from the commit.
- requirements.txt should also be in gitignore and generated automatically as a part of the build process (
pipenv run pip freeze > requirements.txt).
Kilo59
requested changes
Apr 1, 2020
Collaborator
Kilo59
left a comment
Kilo59
left a comment
There was a problem hiding this comment.
IDE files should be ignored
Needs to be updated for FastAPI
https://fastapi.tiangolo.com/deployment/#docker
Kilo59
added
dev
Collaborator
|
Added as part of #251 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it will make it easier for other people to set up and develop their things further, as well as now you can easier automate the deployment on any platform