This repository was archived by the owner on Jun 27, 2020. It is now read-only.
179 redesign report activity #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in RecordAdapter.
…ity for RecordReportAdapter.
yev-kanivets
suggested changes
Sep 5, 2019
Owner
yev-kanivets
left a comment
yev-kanivets
left a comment
There was a problem hiding this comment.
Great work 👍Code can be improved in few places, but very good overall.
| val recordReportConverter = RecordReportConverter(report) | ||
| adapter = ExpandableListReportAdapter(this, recordReportConverter) | ||
| for (categoryRecord in report.summary) { | ||
|
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| if (report != null) { | ||
| val recordReportConverter = RecordReportConverter(report) | ||
| adapter = ExpandableListReportAdapter(this, recordReportConverter) | ||
| for (categoryRecord in report.summary) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| if (position == 0) showReport() | ||
| else editRecord(position) | ||
| recordAdapter = RecordAdapter(this, listOf(), true) | ||
| recordAdapter.setOnItemClickListener { position -> editRecord(position) } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| recordAdapter.setOnItemClickListener { position -> editRecord(position) } | ||
|
|
||
| summaryPresenter = ShortSummaryPresenter(this) | ||
| val summaryView = summaryPresenter.create(true) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| btnAddIncome.setOnClickListener { addIncome() } | ||
| } | ||
|
|
||
| private fun editRecord(position: Int) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
app/src/main/java/com/blogspot/e_kanivets/moneytracker/di/AppComponent.java
Show resolved
Hide resolved
app/src/main/java/com/blogspot/e_kanivets/moneytracker/entity/RecordReportItem.kt
Show resolved
Hide resolved
app/src/main/java/com/blogspot/e_kanivets/moneytracker/report/record/RecordReport.java
Show resolved
Hide resolved
app/src/main/java/com/blogspot/e_kanivets/moneytracker/report/record/model/SummaryRecord.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/blogspot/e_kanivets/moneytracker/ui/presenter/ShortSummaryPresenter.java
Show resolved
Hide resolved
yev-kanivets
approved these changes
Sep 6, 2019
|
|
||
| private fun editRecord(position: Int) { | ||
| AnswersProxy.get().logButton("Edit Record") | ||
| // -1 because SummaryView |
Owner
There was a problem hiding this comment.
This is exactly why comments are bad ⬆️
| btnAddIncome.setOnClickListener { addIncome() } | ||
| } | ||
|
|
||
| private fun getPositionWithoutSummary(position: Int): Int { |
yev-kanivets
approved these changes
Sep 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.