This repository was archived by the owner on Jun 27, 2020. It is now read-only.
#178. Kotlinify ReportActivity. #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yev-kanivets
suggested changes
Aug 28, 2019
Owner
yev-kanivets
left a comment
yev-kanivets
left a comment
There was a problem hiding this comment.
Fast as a 🚀Few improvements and can me shipped.
app/src/main/java/com/blogspot/e_kanivets/moneytracker/activity/ReportActivity.kt
Outdated
Show resolved
Hide resolved
|
|
||
| private lateinit var shortSummaryPresenter: ShortSummaryPresenter | ||
|
|
||
| override fun getContentViewId(): Int { |
Owner
There was a problem hiding this comment.
Can be simplified to override fun getContentViewId() = R.layout.activity_report.
|
|
||
| initSpinnerCurrency() | ||
|
|
||
| shortSummaryPresenter = ShortSummaryPresenter(this) |
Owner
There was a problem hiding this comment.
Probably can be moved to the place, where it's declared.
| val reportMaker = ReportMaker(rateController) | ||
| val report = reportMaker.getRecordReport(currency, period, recordList) | ||
|
|
||
| var adapter: ExpandableListReportAdapter? = null |
Owner
There was a problem hiding this comment.
All code below can be moved into if statement.
| private fun initSpinnerCurrency() { | ||
| val currencyList = currencyController.readAll() | ||
|
|
||
| spinnerCurrency.adapter = ArrayAdapter(this, |
| update(spinnerCurrency.selectedItem.toString()) | ||
| } | ||
|
|
||
| override fun onNothingSelected(p0: AdapterView<*>?) { |
|
|
||
| <android.support.v7.widget.AppCompatSpinner | ||
| android:id="@+id/spinner_currency" | ||
| android:id="@+id/spinnerCurrency" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.