This repository was archived by the owner on Jun 27, 2020. It is now read-only.
Add free build flavor without Crashlytics #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
Author
|
The pull request now also removes dropbox backup/restore feature and thus dependency on |
This reverts commit e30f7af.
Contributor
Author
|
Reverting the previous change as it is not necessary unlike I assumed. |
Yky
reviewed
Aug 28, 2019
| */ | ||
|
|
||
| public class CrashlyticsProxy { | ||
| private static CrashlyticsProxy instance; |
There was a problem hiding this comment.
This singleton implementation is not thread safe. Could be improved with double-checked locking.
| public class AnswersProxy { | ||
| private static AnswersProxy instance; | ||
| public class CrashlyticsProxy { | ||
| private static CrashlyticsProxy instance; |
Owner
|
@fynngodau looks great (even with a possible thread safety issue pointed out by @Yky). Thanks for your contribution 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a
freebuild flavor (as opposed to the newproprietarybuild flavor) which does notcompilethe Google Crashlytics dependency. For this, it utilizes theAnswersProxyclass, which is now different in the different flavors and renamed toCrashlyticsProxyto better account for its purpose. In the proprietary one, it is largely unchanged (one minor change to move the code to init Crashlytics¹), in the free one, it doesn't do anything. Closes #181.¹Not sure how exactly that piece of code works. Functionality shouldn't differ but I haven't tested it.