Skip to content
This repository was archived by the owner on Jun 27, 2020. It is now read-only.

Dev #180

Merged
bogdan-evtushenko merged 12 commits into from
Aug 23, 2019
Merged

Dev #180

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b3f63c2
Update kotlin version
Jul 8, 2019
f31342e
#167. Kotlinify MainActivity.
bogdan-evtushenko Jul 12, 2019
fbc82ea
#167. Add review fixes.
bogdan-evtushenko Jul 12, 2019
c962ba0
#168. Migrate ListView to RecyclerView in MainActivity.
bogdan-evtushenko Jul 17, 2019
0e7a980
#168. Add review fixes.
bogdan-evtushenko Jul 18, 2019
4072e27
#168. Add SummaryViewInterface.
bogdan-evtushenko Jul 18, 2019
f207de6
#168. Add some fixes.
bogdan-evtushenko Jul 18, 2019
282f8b5
#168. Add review fixes.
bogdan-evtushenko Jul 19, 2019
285c58c
#168. Add @Inject in RecordAdapter. Change anonymous class into lambd…
bogdan-evtushenko Jul 19, 2019
ba92df5
#168. Fix bug connected to shortSummary update in first launch.
bogdan-evtushenko Jul 22, 2019
0a708c4
Merge branch 'dev' of github.com:yevhenii-kanivets/Money-Tracker into…
bogdan-evtushenko Aug 23, 2019
0477d1e
Merge branch 'master' into dev
bogdan-evtushenko Aug 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
#168. Fix bug connected to shortSummary update in first launch.
  • Loading branch information
@bogdan-evtushenko
bogdan-evtushenko committed Aug 23, 2019
commit ba92df5c5943deca051bc8055a4647cc1b3aa45d
3 changes: 1 addition & 2 deletions ...gspot/e_kanivets/moneytracker/activity/account/edit/fragment/AccountOperationsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import android.view.View
import com.blogspot.e_kanivets.moneytracker.R
import com.blogspot.e_kanivets.moneytracker.activity.base.BaseFragment
import com.blogspot.e_kanivets.moneytracker.adapter.RecordAdapter
import com.blogspot.e_kanivets.moneytracker.controller.FormatController
import com.blogspot.e_kanivets.moneytracker.controller.data.AccountController
import com.blogspot.e_kanivets.moneytracker.controller.data.RecordController
import com.blogspot.e_kanivets.moneytracker.controller.data.TransferController
Expand Down Expand Up @@ -35,7 +34,7 @@ class AccountOperationsFragment : BaseFragment() {
}

override fun initViews(view: View) {
recyclerView.adapter = RecordAdapter(requireContext(), getRecords(), false)
recyclerView.adapter = RecordAdapter(requireContext(), getRecords(), false, null)
}

private fun getRecords(): List<Record> {
Expand Down
4 changes: 1 addition & 3 deletions app/src/main/java/com/blogspot/e_kanivets/moneytracker/activity/record/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,7 @@ class MainActivity : BaseDrawerActivity() {
tvDefaultAccountSum = navigationView.getHeaderView(0).findViewById(R.id.tvDefaultAccountSum)
tvCurrency = navigationView.getHeaderView(0).findViewById(R.id.tvCurrency)

recordAdapter = RecordAdapter(this, listOf(), true)

recordAdapter.setOnItemClickListener { position ->
recordAdapter = RecordAdapter(this, listOf(), true) { position ->
if (position == 0) showReport()
else editRecord(position)
}
Expand Down
16 changes: 6 additions & 10 deletions app/src/main/java/com/blogspot/e_kanivets/moneytracker/adapter/RecordAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ class RecordAdapter : RecyclerView.Adapter<RecyclerView.ViewHolder> {

private var summaryPresenter: ShortSummaryPresenter
private var isHeaderViewNeeded: Boolean = false
private lateinit var headerViewHolder: HeaderViewHolder
private var headerViewHolder: HeaderViewHolder

constructor(context: Context, records: List<Record>, isHeaderViewNeeded: Boolean) {
constructor(context: Context, records: List<Record>, isHeaderViewNeeded: Boolean, itemClickListener: ((Int) -> Unit)?) {
this.context = context
this.records = records

Expand All @@ -50,7 +50,11 @@ class RecordAdapter : RecyclerView.Adapter<RecyclerView.ViewHolder> {

summaryPresenter = ShortSummaryPresenter(context)

this.itemClickListener = itemClickListener
this.isHeaderViewNeeded = isHeaderViewNeeded

headerViewHolder = HeaderViewHolder(LayoutInflater.from(context).inflate(R.layout.view_summary_records, null), itemClickListener)
summaryPresenter.create(true, headerViewHolder)
}

override fun getItemCount() = records.size + if (isHeaderViewNeeded) 1 else 0
Expand Down Expand Up @@ -92,19 +96,11 @@ class RecordAdapter : RecyclerView.Adapter<RecyclerView.ViewHolder> {
}

fun setRecords(recordsList: List<Record>, report: IRecordReport?, currency: String, ratesNeeded: List<String>) {
if (isHeaderViewNeeded && records.isEmpty()) {
headerViewHolder = HeaderViewHolder(LayoutInflater.from(context).inflate(R.layout.view_summary_records, null), itemClickListener)
summaryPresenter.create(true, headerViewHolder)
}
records = recordsList
summaryPresenter.update(report, currency, ratesNeeded)
notifyDataSetChanged()
}

fun setOnItemClickListener(itemClickListener: (Int) -> Unit) {
this.itemClickListener = itemClickListener
}

class ViewHolder : RecyclerView.ViewHolder {

var container: LinearLayout
Expand Down