This repository was archived by the owner on Jun 27, 2020. It is now read-only.
#168. Migrate ListView to RecyclerView in MainActivity. #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yev-kanivets
suggested changes
Jul 18, 2019
.../main/java/com/blogspot/e_kanivets/moneytracker/activity/account/edit/EditAccountActivity.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/blogspot/e_kanivets/moneytracker/activity/account/edit/EditAccountActivity.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/blogspot/e_kanivets/moneytracker/activity/account/edit/EditAccountActivity.kt
Outdated
Show resolved
Hide resolved
.../java/com/blogspot/e_kanivets/moneytracker/activity/exchange_rate/ExchangeRatesActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/blogspot/e_kanivets/moneytracker/activity/record/MainActivity.kt
Show resolved
Hide resolved
app/src/main/java/com/blogspot/e_kanivets/moneytracker/adapter/RecordAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/blogspot/e_kanivets/moneytracker/adapter/RecordAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/blogspot/e_kanivets/moneytracker/ui/presenter/ShortSummaryPresenter.java
Outdated
Show resolved
Hide resolved
| TextView tvPeriod; | ||
| @BindView(R.id.tv_total_income) | ||
|
|
||
| public TextView getTvPeriod() { |
Owner
There was a problem hiding this comment.
No need for getters here. Just make fields public.
app/src/main/java/com/blogspot/e_kanivets/moneytracker/ui/presenter/ShortSummaryPresenter.java
Outdated
Show resolved
Hide resolved
Owner
yev-kanivets
left a comment
yev-kanivets
left a comment
There was a problem hiding this comment.
Much better 👍 Few fine tunes are still needed though :)
app/src/main/java/com/blogspot/e_kanivets/moneytracker/adapter/RecordAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/blogspot/e_kanivets/moneytracker/adapter/RecordAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/blogspot/e_kanivets/moneytracker/adapter/RecordAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/blogspot/e_kanivets/moneytracker/adapter/RecordAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/blogspot/e_kanivets/moneytracker/adapter/RecordAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/blogspot/e_kanivets/moneytracker/ui/presenter/ShortSummaryPresenter.java
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@yevhenii-kanivets review it please |
…a in rvOnClickListener.
yev-kanivets
approved these changes
Jul 19, 2019
Owner
|
@bogdan-evtushenko following bug has been found while testing:
|
bogdan-evtushenko
force-pushed
the
168_migrate_listView_to_recyclerView_in_MainActivity
branch
from
9fb343b to
bf1f9f7
Compare
yev-kanivets
deleted the
168_migrate_listView_to_recyclerView_in_MainActivity
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.