This repository was archived by the owner on Jun 27, 2020. It is now read-only.
#167. Kotlinify MainActivity. #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
yev-kanivets
left a comment
yev-kanivets
left a comment
There was a problem hiding this comment.
Good job overall 👍 Just few comments.
| private lateinit var tvDefaultAccountSum: TextView | ||
| private lateinit var tvCurrency: TextView | ||
|
|
||
| override fun getContentViewId(): Int { |
Owner
There was a problem hiding this comment.
Kotlin way of doing it would be override fun getContentViewId() = R.layout.activity_main.
|
|
||
| private fun showReport() { | ||
| AnswersProxy.get().logButton("Show Report") | ||
| val intent = Intent(this@MainActivity, ReportActivity::class.java) |
Owner
There was a problem hiding this comment.
@MainActivity isn't needed here and in few other places.
| if (resultCode == AppCompatActivity.RESULT_OK) { | ||
| when (requestCode) { | ||
| REQUEST_ACTION_RECORD -> { | ||
| appComponent.inject(this@MainActivity) |
Owner
There was a problem hiding this comment.
If I remember right it wasn't here before kotlinification.
| } | ||
|
|
||
| override fun update() { | ||
| println("Hello update") |
yev-kanivets
approved these changes
Jul 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.